Code Related Code -> change 2 function's names

[Sheep]

Fatal error: Cannot redeclare fetchchildcategories()
(previously declared in support\modules\knowledgebase\functions_knowledgeb ase.php:373)
in support\modules\downloads\functions_downloads.php on line 87

There's 2 functions having the same name:

PHP Code:

function fetchChildCategories($kbcategoryid, &$tslist) 
function fetchChildCategories($downloadcategoryid, &$tslist) 


they should be renamed to fetchKBChildCategories and fetchDLChildCategories.


atm you can't include the two files at the same time

PHP Code:

require_once ("./modules/knowledgebase/functions_knowledgebase.php");  
require_once ("./modules/downloads/functions_downloads.php"); 


http://www.php.net/language.functions

PHP does not support function overloading, nor is it possible to undefine or redefine previously-declared functions.

[Jamie Edwards]

Adding this as a bug to the bug tracker instead.

[Jamie Edwards]

http://bugs.kayako.com/index.php?cmd=view&id=159

[Sheep]

Well.. it's not really a "bug" as Supportsuite will work perfectly without changing this. That why i posted under Feature Request

This -bug- is encountered when develloping a module and including those 2 files (in kayako's code they are never called in the same time)

Thanks anyway jamie.

[Sheep]

Seems like there's more functions


3 files are in conflict:
modules/knowledgebase/functions_knowledgebase.php
modules/downloads/functions_downloads.php
modules/troubleshooter/functions_troubleshooter.php

as far as i could find here are the other functions in conflicts:

renderCategoryList()

[Jamie Edwards]

To keep things easier and in case you find more, I have kept it as a feature request.

Thanks Antoine!

[Sheep]

Seems like that's all.

patch:

for each file in modules/downloads
replace every fetchChildCategories(
by fetchChildDLCategories(
replace every renderCategoryList(
by renderDLCategoryList(

for each file in modules/knowledgebase
replace every fetchChildCategories(
by fetchChildKBCategories(
replace every renderCategoryList(
by renderKBCategoryList(


for each file in modules/troubleshooter
replace every fetchChildCategories(
by fetchChildTSCategories(
replace every renderCategoryList(
by renderTSCategoryList(


supporsuite seems to be working with no problems.
no more conflicts in my module with triple inclusions

you can close this request as it's solved (and should be submited to the dev team)

Greetings,
Antoine