Code Related Code -> strip_tags is such a pain

[Sheep]

I was playing arround with improving striping in tickets (default configuration = remove all tags, you should add a server setting option, like the mail parser tag, where only some tags aren't stripped)
and then i found out that the php function strip_tags doesn't handle self closing tags like <br/> (and then <br /> used in the wysiwyg editor that i've inserted back to tickets)

kayako should use this function (found in php.net comments, and improved to match kayako's current code)

PHP Code:

    function strip_tags_except($text, $allowed_tags="") {
        $allowed_tags=explode(";",$allowed_tags);
        if (!is_array($allowed_tags))
        return $text;
        if (!count($allowed_tags))
        return $text;
        preg_match_all('!<\s*(/)?\s*([a-zA-Z]+)[^>]*>!',
        $text, $all_tags);
        array_shift($all_tags);
        $slashes = $all_tags[0];
        $all_tags = $all_tags[1];
        foreach ($all_tags as $i => $tag) {
          
        if (in_array($tag, $allowed_tags))
          continue;
        $text =
          preg_replace('!<(\s*' . $slashes[$i] . '\s*'.$tag . '[^>]*)>!',
           '',
            $text);
        }
        return $text;
    } 


Then replace all strip_tags with strip_tags_except (function redefinition not allowed)

[Jamie Edwards]

Good find Sheep, thank you

[Sheep]

oh btw: now the admin setting mailparser "allowed tags" have to be "i;u;br" and no longer "<i><u><br>"

[Siora]

Okay so how do us common folks fix this for our setups?

[Sheep]

create a new file includes/functions_PHPenhanced.php

PHP Code:

<?php
    function strip_tags_except($text, $allowed_tags="") {
        $allowed_tags=explode(";",$allowed_tags);
        if (!is_array($allowed_tags))
        return $text;
        if (!count($allowed_tags))
        return $text;
        preg_match_all('!<\s*(/)?\s*([a-zA-Z]+)[^>]*>!',
        $text, $all_tags);
        array_shift($all_tags);
        $slashes = $all_tags[0];
        $all_tags = $all_tags[1];
        foreach ($all_tags as $i => $tag) {
 
        if (in_array($tag, $allowed_tags))
          continue;
        $text =
          preg_replace('!<(\s*' . $slashes[$i] . '\s*'.$tag . '[^>]*)>!',
           '',
            $text);
        }
        return $text;
    }
?>

open config/config.php
add before the closing ?>

PHP Code:

require_once ("./includes/functions_PHPenhanced.php"); 


in all esupport files rename all the strip_tags to strip_tags_except (18 occurences)
if a call doesn't have a second argument add it (in red):

strip_tags_except($firstargument,$_SWIFT["settings"]["pr_allowabletags"]);

[Siora]

Does anyone know how to go about finding the occurences of this call? I would think that there has be be a better way than opening up every file and doing a search.

[bear]

Originally Posted by Siora

Does anyone know how to go about finding the occurences of this call? I would think that there has be be a better way than opening up every file and doing a search.

Best way I know of is to use a good text editor like UltraEdit that can search in files that aren't open, recursively, right on your local hard drive. I've attached the results.

[Jamie Edwards]

Nice on, bear - thank you for sharing.

[Siora]

Yes Bear, much appreciated. I'm sure that will help many out who want to apply this fix.

[Siora]

After doing this mod I get the attached error. Anyone know what it is or how to fix it? After about 2 seconds the error disappears and logs in correctly but you can see it between page loads.

EDIT: I also get fatal errors when trying use the IRS from with the staff CP. Not sure if I'm liking this.

[Sheep]

Make sure that there's no spaces before <? or after ?>
in includes/functions/functions_PHPenhanced.php (and maybe functions.php?)

Greetings,
antoine

[Siora]

I don't have an includes/functions folder. For me its just includes/functions_phpenhanced.php. Am I supposed to create a functions folder? Attached is my php file that I created.

The functions.php file looks scrambled, its not plain text.

I think the problem is with my config file. Here is how I put the line at the very bottom. Is this correct?

$_MODULES[MODULE_PURCHASE] = dirname(__FILE__)."/../modules/purchase/purchase.php";
$_MODULES[MODULE_SERVERS] = dirname(__FILE__)."/../modules/servers/servers.php";
$_MODULES[MODULE_REPORTS] = dirname(__FILE__)."/../modules/reports/reports.php";
require_once ("./includes/functions_PHPenhanced.php");
?>

[Sheep]

Ho right,

i wrote

create a new file includes/functions/functions_PHPenhanced.php

it's in fact (as you're stating)

create a new file includes/functions_PHPenhanced.php

Did you check the "maybe something before the ?>" bug?

The functions.php file looks scrambled, its not plain text.

it's encrypted, so this file isn't the problem (just though about it when you stated it)

Edit: contact me via MSN if you're still having problems I'll be online this afternoon

[Siora]

If you look at my attached file it doesn't appear as though anything is before the ?> like you stated. Maybe i'm not understanding.

[Sheep]

Remove the one at the end after ?>