[MODULE] SERM (Supportsuite Enhanced Right Management)

[Vincent]

Hi,

Already done that... several times...

And good morning to you

Greetzzz Vincent

[Sheep]

That's pretty strange... look for any php errors in your php.log
(wow... woke up for a boring course at uni... good morning! )

[Matthew]

There are two things about SERM that seem in need of fixing.

1. If the client interface user is not associated with a Rights Group which has resource folders assigned to it, the user will receive a blank page when clicking on Troubleshooters, Knowledgebase, or Downloads.
2. When a user has access to a resource folder, but not its sub-folders (which in this example contains items), the accessible folder will still display the total number of items in itself AND all its subfolder(s).

I imagine the first bug is relatively easy to fix, with second one involving a lot more work.

Sheep, would you have a quick fix for the first issue?

[Sheep]

The first point is not exactly a bug:

I'm using a TRIGGER_ERROR to stop the process

PHP Code:

trigger_error($fatalmessage, E_USER_ERROR); 


PHP: trigger_error - Manual
PHP: Errors and Logging - Manual
Most webhosters set (in php.ini) the error_level to NULL wich means that the script will stop but won't display the error message to the front user.
So in fact, it's not a white page : it's a page where you -should- see "you're not allowed to see this ressource". SERM is configured to "deny all acess by default".

The improvment should be: "add an error handler" to supportsuite
PHP: set_error_handler - Manual
Customising the PHP error handler
This should be done in index.php after the swift include.

This is a followup to a previous "feature request":
System -> A good, consistent error handler
As you can see in my previous quote i'm using the error_level "E_USER_ERROR" that could be catched in the error handler and displayed nicely using the default template (the error_handler ignores the error_level) as it's not a security flaw to display those errors (but php fatals shouldn't be displayed).

(You can do it by yourself it's not hard)



For the second point, i agree that it should be "fixed" (i'd say improved)
BUT
there is something that was not written in this topic (it's been said in other ones): i've left the kayako community (i was a trainee at the time i wrote this module). I've never used this module for myself and i don't even use supportsuite now (i don't need it, i'm a student ). I don't want to improve the module because i don't know how much time it will take me. That's why this module is given to the community: i hope that someone will continue it. I'm first when it comes to say "this module" isn't -complete-.

I'm a bit sorry to say that i -won't do it- (it's all about motivations)

I've subscribed to the topics i've created because i dislike to leave something not working (so i'm helping a bit people that need helps), but i've told myself to limit my implication.

Sorry again.
Antoine

[Matthew]

Originally Posted by Sheep

(You can do it by yourself it's not hard)

Umm... Ok. You mean, no free lunch?

Originally Posted by Sheep

For the second point, i agree that it should be "fixed" (i'd say improved)
BUT
there is something that was not written in this topic (it's been said in other ones): i've left the kayako community

Yeah, we know that. And a damn shame it is, too, looking at some of the gems you provided!

So go on then... go away. Leave us to mope about, trying to dissect Kayako and make everything work as we'd really like it, while you attend to your studies, drink beer, and ogle campus beauties. We'll be fine here, really we will...

[Sheep]

Damn you, i'm feeling guilty now (don't worry, i understand your matter )

Now that i think about it, i'll agree with the fact that the first part can be -very quickly- done...
I might get some free time around the 22/23 feb.
I'll see if i can do anything then (it's not a promise, i'm moving from my study town to my training course town in april... quite a quest).

[Vincent]

Hope that you have some time then... Anyway thanks for the assistance so far..

[Matthew]

Originally Posted by Vincent

Hope that you have some time then... Anyway thanks for the assistance so far..

I guess we're out of luck. This is one sheep that's off to greener pastures.... <sigh>

[Sheep]

Sincerely sorry matthew, i got overloaded with my ending semester and i couldn't get time for myself. I'm moving to Lyon (my new town) tomorrow (and i'll discover my first job monday at sopragroup). I should get back Internet in arround 2/3weeks (i hope) and then i'll have plenty of free time (no more school work!). I'll fix the matter at that time (this is a promise).

[Matthew]

Originally Posted by Sheep

Sincerely sorry matthew, i got overloaded with my ending semester and i couldn't get time for myself. I'm moving to Lyon (my new town) tomorrow (and i'll discover my first job monday at sopragroup). I should get back Internet in arround 2/3weeks (i hope) and then i'll have plenty of free time (no more school work!). I'll fix the matter at that time (this is a promise).

Thanks Antoine. Good luck with the new job and the city.

You know, it seems to me that the first issue that I previously mentioned has been fixed in recent CVS builds:

There are two things about SERM that seem in need of fixing.

1. If the client interface user is not associated with a Rights Group which has resource folders assigned to it, the user will receive a blank page when clicking on Troubleshooters, Knowledgebase, or Downloads.
2. When a user has access to a resource folder, but not its sub-folders (which in this example contains items), the accessible folder will still display the total number of items in itself AND all its subfolder(s).

Can any other SERM users confirm this?

But wouldn't you know it... there's another little bit that might need twiddling--or maybe just a note here.

I'm using both SERM and the IRS search-in-KB-title mod. But the IRS search was not working; it simply would refuse to return any hits. I've traced the problem to this modification, where you say:

If you're using SERM replace (around line 65 of modules/knowledgebase/functions_irs.php):

$dbCore->query("SELECT kbarticlelinks.kbarticleid, MATCH(kbarticledata.contents) AGAINST ('". $dbCore->escape($_finalworddata) ."') AS relevance FROM `". TABLE_PREFIX ."kbarticledata` AS kbarticledata LEFT JOIN `". TABLE_PREFIX ."kbarticlelinks` AS kbarticlelinks ON (kbarticledata.kbarticleid = kbarticlelinks.kbarticleid) LEFT JOIN `". TABLE_PREFIX ."tgroupassigns` AS tgroupassigns ON (kbarticlelinks.kbcategoryid = tgroupassigns.toassignid AND tgroupassigns.type = '". TGROUP_KNOWLEDGEBASE ."') WHERE ". sermFilterAsQuery('kbcategoryid',$_SWIFT["user"]["usergroupid"],'kb')." AND tgroupassigns.tgroupid = '". intval($_SWIFT["tgroup"]["tgroupid"]) ."' AND MATCH(kbarticledata.contents) AGAINST('". $dbCore->escape($_finalworddata) ."') LIMIT 5;");

with:

$dbCore->query("SELECT kbarticlelinks.kbarticleid, MATCH(kbarticledata.contents) AGAINST ('". $dbCore->escape($_finalworddata) ."') AS relevance, MATCH(kbarticles.subject) AGAINST ('". $dbCore->escape($_finalworddata) ."') AS relevancetitle FROM `". TABLE_PREFIX ."kbarticledata` AS kbarticledata LEFT JOIN `". TABLE_PREFIX ."kbarticlelinks` AS kbarticlelinks ON (kbarticledata.kbarticleid = kbarticlelinks.kbarticleid) LEFT JOIN `". TABLE_PREFIX ."tgroupassigns` AS tgroupassigns ON (kbarticlelinks.kbcategoryid = tgroupassigns.toassignid AND tgroupassigns.type = '". TGROUP_KNOWLEDGEBASE ."') LEFT JOIN `". TABLE_PREFIX ."kbarticles` AS kbarticles ON kbarticledata.kbarticleid=kbarticles.kbarticleid WHERE ". sermFilterAsQuery('kbcategoryid',$_SWIFT["user"]["usergroupid"],'kb')." AND tgroupassigns.tgroupid = '". intval($_SWIFT["tgroup"]["tgroupid"]) ."' AND (MATCH(kbarticledata.contents) AGAINST('". $dbCore->escape($_finalworddata) ."') OR MATCH (kbarticles.subject) AGAINST ('". $dbCore->escape($_finalworddata) ."')) LIMIT 5 ");

THAT little bit, or rather something in the sermFilterAsQuery() in functions_serm.php, is breaking things. If I return that line to the original, however, things seem to work. I can search KB titles and I don't seem to be getting hits on articles that beyond the current user's SERM rights.

[Sheep]

Hi there,

Internet is finally working in my new flat

You know, it seems to me that the first issue that I previously mentioned has been fixed in recent CVS builds:

Ah? Did they insert an error_handler? That would save me from doing it
** Sheep - completly out of what supporsuite has become**

If it's not the case, i'll do it tomorrow or friday.

There are two things about SERM that seem in need of fixing.

1. If the client interface user is noB�20associated wiúp a"RiF¾ts Group which has resource folders `ssigned to it, the user will receive a blank page when clicking on Troubleshooters, Knowledgebase, or Downloads.
2. When a user has access to a resource folder, but not its sub-folders (which in this example contains items), the accessible folder will still display the total number of items in itself AND all its subfolder(s).

I've already answered the 2 points

1) It's half a bug. SERM is denying all acess by default. It's not showing a blank page: it's triggering an error but your php.ini is set so it doesn't display this error (so we need an error handler! That's what i promised i'd do).

2) I'd say yes, i don't remember changing this part... but i'll put it in the "improvment request" folder (and then you sadly know what my answer is)...

sermFilterAsQuery() in functions_serm.php, is breaking things.

Hmm? I can't tell like that...
Can you tell me what php error does it makes? (php logs?)

[Sheep]

Hi Matthew, sorry for the little delay.

Can you try this error handler? (add it in index.php just after

PHP Code:

require_once ("./swift.php"); 


This is complete blind coding: i can't test it myself (no licence).
You should contact me on msn (GMT+1).

PHP Code:

function customErrorHandler($errno, $errstr, $errfile, $errline)
{
    global $template;
    
    switch ($errno) {
    case E_USER_ERROR:
    
        $template->assign("errormessage", $errstr);
        echo $template->displayTemplate("header");
        echo $template->displayTemplate("footer");
        exit(1);
        break;
    case E_USER_WARNING:
        //echo "<b>WARNING</b> [$errno] $errstr<br />\n";
        break;
    case E_USER_NOTICE:
        //echo "<b>NOTICE</b> [$errno] $errstr<br />\n";
        break;
    default:
        //echo "Unknown error type : [$errno] $errstr<br />\n";
        break;
    }
   return false; //let the normal debugger continue (not in the E_USER_ERROR case)
}
set_error_handler("customErrorHandler"); 


[Armen]

Hi there!
I understand that most likely I'm "too late" in this discussion and SERM is the passed day for our respected Sheep, who enjoys now of his new job and beauties in Lyon :-), but maybe I'll be lucky and somebody is still interesting in this topic... So, the problem is that neither
http://myownaddress.something/support/setup/
nor
http://mysite.domain/support/setup/
cannot be found in WEB :-(
After I made all the changes in sources accordingly to setup.php, I reached the point where I need to go to any of above sites and here oops... they do not exist anymore :-(
Does anybody know what can I do now? Maybe another address is active..?

[Sheep]

but maybe I'll be lucky and somebody is still interesting in this topic

I'm still getting notification emails


To solve your matter, if the setup folder doesn't exist anymore just reupload the one that is inside the Supportsuite package.

BTW: http://myownaddress.something/support/setup/ is just a sample adress, yours could be http://insertyourdomainname.net/setup/ (no "support" subfolder)

[Armen]

Thanks Antoine, I got it. And it is installed now. Though now I have another problem. Following First time guide, I did all the steps:

- Go the staff panel
- Go to the “rights” tab > Manage rights
- Create a subgroup (from the root) called guest
- Create a subgroup (from guest) called registered
- Go to Manage Usergroups
- Click on Guest
- Click on the RightGroups tab
- Check the Guest mark

But I can't do the very last item - "Submit", since there is NO Submit button on the page. I'm digging in sources now, trying to find out why it is so.
I'm afraid SERM becomes incompatible with the newest versions of Support Suit (I'm using v.3.20.02)