Free View Ticket: Hide tabs

[phpimpact]

If you want to prevent users replying or releasing other users tickets, you can hide the "Post reply" and "Release" tabs (or any other tab).

1. Open this file /modules/tickets/staff_viewticket.php with notepad.

2. Add this somewhere on the top of the document (line 99 will do, after the $navtitled variable):

PHP Code:

    $userIsAdmin = (bool) $_SWIFT["staff"]['is_admin'];
    $userTicketOwnerId = (int) $_ticket["ownerstaffid"]; 
    $userOwnsTicket = ($_SWIFT["staff"]['staffid'] === $_ticket["ownerstaffid"]) ? true : false; 


3. Almost there. After line 150, the script prints the list tags <li>, that are part of the tabs.

4. Wrap the echo between an if statement:

PHP Code:

    if ($userIsAdmin === true 
        || $userOwnsTicket === true
        || $userTicketOwnerId === 0)
    {
        echo ...
    } 


If the user is not an administrator ($userIsAdmin), or if he doesn't own the ticket ($userOwnsTicket), he'll not see the tabs. If the ticket is --unassigned-- ($userTicketOwnerId), all the users will see the tabs.

That's it!

[Siora]

This is a great mod but how would this effect managers who are not admins. Managers are those that oversee their team and assign tickets accordingly but do not have access to the admin side of things. Can this be added to the mod?

[craigbrass]

Ooo, this is good. Thanks for sharing!

[mopa]

can this maybe be altered so it hides these tabs for a specific staff group instead?

[craigbrass]

Originally Posted by mopa

can this maybe be altered so it hides these tabs for a specific staff group instead?

I would like to see the ability to do this too.

[Siora]

Yes that would make sense as this would also solve my question.

[phpimpact]

Yeah sure, you have to add the following line bellow $userOwnsTicket...

PHP Code:

// add the id's of the groups that can view the tabs
$allowedGroupIds = array(3, 5, 7);
$userGroupId = (int) $_SWIFT["staff"]["staffgroupid"]; 


And then wrap the echo between an if statement:

PHP Code:

if (in_array($userGroupId, $allowedGroupIds))
{
    echo ...
} 


That's all

[phpimpact]

The quickest way to find out the ID number of a group is logging in as admin and going to: Staff > Manage Team.

Click on a team and check the URL, it should end with something like this: index.php?_m=core&_a=editstaffgroup&staffgroupid=4

So there you have it, "staffgroupid" 4

$allowedGroupIds = array(4); 

[Siora]

Originally Posted by phpimpact

Yeah sure, you have to add the following line bellow $userOwnsTicket...

PHP Code:

// add the id's of the groups that can view the tabs
$allowedGroupIds = array(3, 5, 7);
$userGroupId = (int) $_SWIFT["staff"]["staffgroupid"]; 


And then wrap the echo between an if statement:

PHP Code:

if (in_array($userGroupId, $allowedGroupIds))
{
    echo ...
} 


That's all

Is this the full code or do we still have to add statements/code? Besides changing the groupID's is there anything else we need to add ourselves? Sorry I'm not a coder so I wouldn't know what to add if we did.

[mopa]

And then wrap the echo between an if statement:

PHP Code:

if (in_array($userGroupId, $allowedGroupIds))
{
    echo ...
} 


That's all

Sorry I don't quite get what that means?
Where should this be copied to? Can you please specify?
(because when I put it in somewhere - I end up with a blank page when clicking on a ticket with that usergroup)

[phpimpact]

Hi guys, sorry if I wasn't clear enough.

It's similar to the first post, but we are going to add a couple of extra lines:

1. Open this file /modules/tickets/staff_viewticket.php with notepad.

2. Add this somewhere on the top of the document (line 99 will do, after the $navtitled variable):

PHP Code:

$userIsAdmin = (bool) $_SWIFT["staff"]['is_admin'];
$userTicketOwnerId = (int) $_ticket["ownerstaffid"]; 
$userOwnsTicket = ($_SWIFT["staff"]['staffid'] === $_ticket["ownerstaffid"]) ? true : false; 

$allowedGroupIds = array(3, 5, 7);
$userGroupId = (int) $_SWIFT["staff"]["staffgroupid"]; 


Note that now we have added 2 new lines, $allowedGroupIds and $userGroupId.

3. Almost there. After line 150, the script prints the list tags <li>, that are part of the tabs.

4. Wrap the echo between an if statement:

You have different options:

4.1. Option 1

PHP Code:

if ($userIsAdmin === true
    || $userOwnsTicket === true
    || $userTicketOwnerId === 0)
{
    echo <li>...
} 


If the user is not an administrator ($userIsAdmin), or if he doesn't own the ticket ($userOwnsTicket), he'll not see the tabs. If the ticket is --unassigned-- ($userTicketOwnerId), all the users will see the tabs.

4.2. Option 2

PHP Code:

if (in_array($userGroupId, $allowedGroupIds))
{
    echo <li>...
} 


This will show the tab only to groups with the ID 3, 4 and 5. You can change the ID of the allowed groups by editing the line: $allowedGroupIds = array(3, 5, 7);

4.3. Option 3

PHP Code:

if ($userIsAdmin === true 
    || $userOwnsTicket === true 
    || $userTicketOwnerId === 0 
    || in_array($userGroupId, $allowedGroupIds))
{
    echo <li>...
} 


This combines options 1 and 2.

Hope this helps

[mopa]

Thanks alot

I really love this mod now that I can exclude specific groups.

[phpimpact]

Pay attention to this line: array(group_id, group_id, etc), it holds the group id's, example:

PHP Code:

$allowedGroupIds = array(4, 5, 7); 


The quickest way to find out the ID number of a group is logging in as admin and going to: Staff > Manage Team.

Click on a team and check the URL, it should end with something like this: index.php?_m=core&_a=editstaffgroup&staffgroupid=4

So there you have it, "staffgroupid" 4

PHP Code:

  $allowedGroupIds = array(4); 


You can add as many id's as you want:

PHP Code:

  $allowedGroupIds = array(4, 5, 7, 9); 


[Siora]

Okay I'm confused. There are a few echo <li> statements around line 150. Some are already wrapped around if statements and one of them isn't. Here is a section of code:

<li><a class="currenttab" href="#" onClick="this.blur(); return switchGridTab(\'ttgeneral\', \'tickets\');" id="ttgeneral" title="'. $_SWIFT["language"]["tabgeneral"] .'">'. $_SWIFT["language"]["tabgeneral"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'ttpostreply\', \'tickets\'); document.replyform.replycontents.focus(); EDITORON(); startTicketLock(\''. intval($_ticket["ticketid"]) .'\');" id="ttpostreply" title="'. $_SWIFT["language"]["tabpostreply"] .'">'. $_SWIFT["language"]["tabpostreply"] .'</a></li>';
 if ($_SWIFT["staff"]["tforward"] != "0")
 {
  echo '<li><a href="#" onClick="this.blur();switchGridTab(\'ttforward\', \'tickets\');if (!loadedStates[\'forward\']) {fetchData(\'forward\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttforward" title="'. $_SWIFT["language"]["tabforward"] .'">'. $_SWIFT["language"]["tabforward"] .'</a></li>';
 }
 echo '<li><a href="#" onClick="this.blur();switchGridTab(\'ttfollowup\', \'tickets\');if (!loadedStates[\'followup\']) {fetchData(\'followup\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttfollowup" title="'. $_SWIFT["language"]["tabfollowup"] .'">'. $_SWIFT["language"]["tabfollowup"] .'</a></li>';
 if ($_SWIFT["staff"]["tbilling"] != "0")
 {
  echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttbilling\', \'tickets\');if (!loadedStates[\'billing\']) {fetchData(\'billing\', \''. $_ticket["ticketid"] .'\');}" id="ttbilling" title="'. $_SWIFT["language"]["billing"] .'">'. $_SWIFT["language"]["billing"] .'</a></li>';
 }
 $_total = $dbCore->queryFetch("SELECT COUNT(*) AS totalitems FROM `". TABLE_PREFIX ."tickets` WHERE `email` = '". $dbCore->escape($_ticket["email"]) ."';");
 $_tickethistorycount = intval($_total["totalitems"]);
 if ($_tickethistorycount > 0)
 {
  $_strhistorycount = ' <font color="#CF5D60">('. $_tickethistorycount .')';
 } else {
  $_strhistorycount = ' (0)';
 }
 echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttaddnotes\', \'tickets\');if (!loadedStates[\'addnotes\']) {fetchData(\'addnotes\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttaddnotes" title="'. $_SWIFT["language"]["tabaddnotes"] .'">'. $_SWIFT["language"]["tabaddnotes"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'ttrelease\', \'tickets\');if (!loadedStates[\'release\']) {fetchData(\'release\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttrelease" title="'. $_SWIFT["language"]["tabrelease"] .'">'. $_SWIFT["language"]["tabrelease"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'tthistory\', \'tickets\');if (!loadedStates[\'history\']) {fetchData(\'history\', \''. $_ticket["email"] .'\');}" id="tthistory" title="'. $_SWIFT["language"]["tabhistory"] .'">'. sprintf($_SWIFT["language"]["tabhistorycnt"], $_strhistorycount) .'</a></li>';
 
 if ($module->isRegistered(MODULE_LIVESUPPORT) && !empty($_ticket["email"]))
 {
  $_total = $dbCore->queryFetch("SELECT COUNT(*) AS totalitems FROM `". TABLE_PREFIX ."chatobjects` WHERE `useremail` = '". $dbCore->escape($_ticket["email"]) ."';");
  $_chatcount = intval($_total["totalitems"]);
  if ($_chatcount > 0)
  {
   $_strchatcount = ' <font color="#CF5D60">('. $_chatcount.')';
  } else {
   $_strchatcount = ' <font color="gray">(0)</font>';
  }
  echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttlschats\', \'tickets\');if (!loadedStates[\'lschats\']) {fetchData(\'lschats\', \''. "&email[]=".urlencode($_ticket["email"]) .'\');}" id="ttlschats" title="'. $_SWIFT["language"]["strchats"] .'">'. sprintf($_SWIFT["language"]["tabchats"], $_strchatcount) .'</a></li>';
 }
 echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttlog\', \'tickets\');if (!loadedStates[\'auditlog\']) {fetchData(\'auditlog\', \''. $_ticket["ticketid"] .'\');}" id="ttlog" title="'. $_SWIFT["language"]["tablog"] .'">'. $_SWIFT["language"]["tablog"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'ttedit\', \'tickets\');if (!loadedStates[\'edit\']) {fetchData(\'edit\', \''. $_ticket["ticketid"] .'\');}" id="ttedit" title="'. $_SWIFT["language"]["tabedit"] .'">'. $_SWIFT["language"]["tabedit"] .'</a></li>
 </ul></div></td></tr>'.SWIFT_CRLF;

Where do I wrap the if?

[mopa]

I didn't do it my self, but here is some code from mine that works.
I removed ALL the tabs from the usergroup 3.

My code is taken from line 140 - 214

I can't really help you more, but maybe you can see something you can use from it.

PHP Code:

    $userIsAdmin = (bool) $_SWIFT["staff"]['is_admin'];
    $userTicketOwnerId = (int) $_ticket["ownerstaffid"];
    $userOwnsTicket = ($_SWIFT["staff"]['staffid'] === $_ticket["ownerstaffid"]) ? true : false;
    // add the id's of the groups that can view the tabs
    $allowedGroupIds = array(1, 2);
    $userGroupId = (int) $_SWIFT["staff"]["staffgroupid"];
 
 $interface->staffNavBar($nav, "", 2);
 printInfoBox($_SWIFT["infomessage"]);
 printErrorBox($_SWIFT["errormessage"]);
    if (in_array($userGroupId, $allowedGroupIds))
    {
    echo '<table cellspacing="0" cellpadding="0" border="0" width="100%" id="tickettableopt'. $_ticket["ticketid"] .'"><tr style="height: 1em"><td align="left"><div id="ticketopt'. $_ticket["ticketid"] .'"><ul id="tab">
 <li><a class="currenttab" href="#" onClick="this.blur(); return switchGridTab(\'ttgeneral\', \'tickets\');" id="ttgeneral" title="'. $_SWIFT["language"]["tabgeneral"] .'">'. $_SWIFT["language"]["tabgeneral"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'ttpostreply\', \'tickets\'); document.replyform.replycontents.focus(); startTicketLock(\''. intval($_ticket["ticketid"]) .'\');" id="ttpostreply" title="'. $_SWIFT["language"]["tabpostreply"] .'">'. $_SWIFT["language"]["tabpostreply"] .'</a></li>';
 if ($_SWIFT["staff"]["tforward"] != "0")
 {
  echo '<li><a href="#" onClick="this.blur();switchGridTab(\'ttforward\', \'tickets\');if (!loadedStates[\'forward\']) {fetchData(\'forward\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttforward" title="'. $_SWIFT["language"]["tabforward"] .'">'. $_SWIFT["language"]["tabforward"] .'</a></li>';
 }
 echo '<li><a href="#" onClick="this.blur();switchGridTab(\'ttfollowup\', \'tickets\');if (!loadedStates[\'followup\']) {fetchData(\'followup\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttfollowup" title="'. $_SWIFT["language"]["tabfollowup"] .'">'. $_SWIFT["language"]["tabfollowup"] .'</a></li>';
 if ($_SWIFT["staff"]["tbilling"] != "0")
 {
  echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttbilling\', \'tickets\');if (!loadedStates[\'billing\']) {fetchData(\'billing\', \''. $_ticket["ticketid"] .'\');}" id="ttbilling" title="'. $_SWIFT["language"]["billing"] .'">'. $_SWIFT["language"]["billing"] .'</a></li>';
 }
 $_total = $dbCore->queryFetch("SELECT COUNT(*) AS totalitems FROM `". TABLE_PREFIX ."tickets` WHERE `email` = '". $dbCore->escape($_ticket["email"]) ."';");
 $_tickethistorycount = intval($_total["totalitems"]);
 if ($_tickethistorycount > 0)
 {
  $_strhistorycount = ' <font color="#CF5D60">('. $_tickethistorycount .')';
 } else {
  $_strhistorycount = ' (0)';
 }
 echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttaddnotes\', \'tickets\');if (!loadedStates[\'addnotes\']) {fetchData(\'addnotes\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttaddnotes" title="'. $_SWIFT["language"]["tabaddnotes"] .'">'. $_SWIFT["language"]["tabaddnotes"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'ttrelease\', \'tickets\');if (!loadedStates[\'release\']) {fetchData(\'release\', \''. $_ticket["ticketid"] .'\', \''. intval($_REQUEST["ticketlabelid"]) .'\');}" id="ttrelease" title="'. $_SWIFT["language"]["tabrelease"] .'">'. $_SWIFT["language"]["tabrelease"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'tthistory\', \'tickets\');if (!loadedStates[\'history\']) {fetchData(\'history\', \''. $_ticket["email"] .'\');}" id="tthistory" title="'. $_SWIFT["language"]["tabhistory"] .'">'. sprintf($_SWIFT["language"]["tabhistorycnt"], $_strhistorycount) .'</a></li>';
 if ($module->isRegistered(MODULE_LIVESUPPORT) && !empty($_ticket["email"]))
 {
  $_total = $dbCore->queryFetch("SELECT COUNT(*) AS totalitems FROM `". TABLE_PREFIX ."chatobjects` WHERE `useremail` = '". $dbCore->escape($_ticket["email"]) ."';");
  $_chatcount = intval($_total["totalitems"]);
  if ($_chatcount > 0)
  {
   $_strchatcount = ' <font color="#CF5D60">('. $_chatcount.')';
  } else {
   $_strchatcount = ' <font color="gray">(0)</font>';
  }
  echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttlschats\', \'tickets\');if (!loadedStates[\'lschats\']) {fetchData(\'lschats\', \''. "&email[]=".urlencode($_ticket["email"]) .'\');}" id="ttlschats" title="'. $_SWIFT["language"]["strchats"] .'">'. sprintf($_SWIFT["language"]["tabchats"], $_strchatcount) .'</a></li>';
 }
 echo '<li><a href="#" onClick="this.blur(); switchGridTab(\'ttlog\', \'tickets\');if (!loadedStates[\'auditlog\']) {fetchData(\'auditlog\', \''. $_ticket["ticketid"] .'\');}" id="ttlog" title="'. $_SWIFT["language"]["tablog"] .'">'. $_SWIFT["language"]["tablog"] .'</a></li>
 <li><a href="#" onClick="this.blur(); switchGridTab(\'ttedit\', \'tickets\');if (!loadedStates[\'edit\']) {fetchData(\'edit\', \''. $_ticket["ticketid"] .'\');}" id="ttedit" title="'. $_SWIFT["language"]["tabedit"] .'">'. $_SWIFT["language"]["tabedit"] .'</a></li>
 </ul></div></td></tr>'.SWIFT_CRLF;
 echo '<tr style="height: 1em"><td align="left">'.SWIFT_CRLF;
    } else
    {
     echo '<table cellspacing="0" cellpadding="0" border="0" width="100%" id="tickettableopt'. $_ticket["ticketid"] .'"><tr style="height: 1em">
     <td align="left">
     <div id="ticketopt'. $_ticket["ticketid"] .'">
     </div></td></tr>'.SWIFT_CRLF;
    }
 
 echo '<tr style="height: 1em"><td align="left">'.SWIFT_CRLF;