improve dbcore

[Sheep]

Jamie could you tell a core develloper about a quick fix that i -need-, please?

I can't see it (because the function.php is encoded and i think that the global $dbcore is defined here) but i guess that the dbcore is based on the mysql_query()

but
http://www.php.net/manual/en/function.mysql-query.php

mysql_query() sends an unique query (multiple queries are not supported) to the currently active database

the UNIQUE query is what is disturbing me as i need a multiple querry

PHP Code:

$dbCore->query("SELECT @myLeft := lft, @myRight := rgt FROM swsermrightgroup WHERE rightgroupid = $groupid;");
$dbCore->query("SELECT rightgroupid,name FROM swsermrightgroup WHERE lft<@myLeft AND rgt>@myRight ORDER BY rightgroupid;"); 


would become

PHP Code:

$dbCore->query("SELECT @myLeft := lft, @myRight := rgt FROM swsermrightgroup WHERE rightgroupid = $groupid;
SELECT rightgroupid,name FROM swsermrightgroup WHERE lft<@myLeft AND rgt>@myRight ORDER BY rightgroupid;"); 


The difference comes that only 1 transaction is opened. (performance and request integrity: no other transaction should interupt this one between the 2 request). Currently, a double acces (an other php page called in the same time) might execute a query between the two queries and could change the results that i should expect (i think. But i'm not 100% sure as this part is hidden).

The following comment is a nice tips on how to handle multiple queries
http://www.php.net/manual/en/functio...uery.php#37870

PHP Code:

function mysql_exec_batch ($p_query, $p_transaction_safe = true) {
  if ($p_transaction_safe) {
      $p_query = 'START TRANSACTION;' . $p_query . '; COMMIT;';
    };
  $query_split = preg_split ("/[;]+/", $p_query);
  foreach ($query_split as $command_line) {
    $command_line = trim($command_line);
    if ($command_line != '') {
      $query_result = mysql_query($command_line);
      if ($query_result == 0) {
        break;
      };
    };
  };
  return $query_result;
} 


The

PHP Code:

 'START TRANSACTION;' . $p_query . '; COMMIT;'; 


Is what is interesting.
I could do a dbcore query with START TRANSACTION every time (but damn that's quite boring!)

changing the dbCore->query won't change anything in the actual code but will allow developpers to handle multiple querry.


If the answer is "sorry this won't be done" that's no problem because i'll define it by myself but i think this can be a core improvment.

Greetings,
Antoine

[Jamie Edwards]

Provided that transactions are supported, then yes you can use transactions and strung queries. Multiple databases will also be supported in the next product line version.

[Sheep]

Edit: hmm wait, i think i have read too fast your message. You're telling me that transaction is alread used, ok, then forget my post
Edit: hmm, duplicates? woops